fix env to work in electron correctly

The problem is: electron env includes and browser and nodejs together. Therefore, both isBrowser and isNodejs function will return true. The comment in the code mentions, that isBrowser is explictly called first to prevent electron renderer process to be initialized with wrong environment due to isNodejs() returning true. But current code (before the change) executes both isBrowser and isNodejs blocks. This commit resolves the issue.

fix env to work in electron correctly
c04ecdc4 · Alexander Gusev · 8609b25a · c04ecdc4
Commit c04ecdc4 authored Apr 19, 2020 by Alexander Gusev
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

index.ts src/env/index.ts +2 -2

No files found.
--- a/src/env/index.ts
+++ b/src/env/index.ts
@@ -22,10 +22,10 @@ function initialize() {
  // check for isBrowser() first to prevent electron renderer process
  // to be initialized with wrong environment due to isNodejs() returning true
  if (isBrowser()) {
-    setEnv(createBrowserEnv())
+    return setEnv(createBrowserEnv())
  }
  if (isNodejs()) {
-    setEnv(createNodejsEnv())
+    return setEnv(createNodejsEnv())
  }
 }